Re: [PATCH 1/1] net: sched: Deletion of an unnecessary check before the function call "kfree"

From: Daniel Borkmann
Date: Wed Nov 19 2014 - 12:00:59 EST

On 11/19/2014 05:47 PM, John Fastabend wrote:
On 11/18/2014 12:26 PM, SF Markus Elfring wrote:
From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
if (fp_old)
- if (bpf_old)
- kfree(bpf_old);
+ kfree(bpf_old);

return 0;

Maybe I need some coffee but I can't figure out what this
patch is against...

# grep bpf_old ./net/sched/cls_bpf.c

Coffee is always good. :)

Yeah, you actually removed this in commit 1f947bf151e90ec ("net:
sched: rcu'ify cls_bpf"), so looks like Markus's tree is not
up to date ...
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at