Re: [PATCH] platform: x86: dell-laptop: Add support for keyboard backlight

From: Pali RohÃr
Date: Wed Nov 19 2014 - 14:51:38 EST

On Wednesday 19 November 2014 20:23:36 Matthew Garrett wrote:
> On Wed, Nov 19, 2014 at 10:34:16AM -0800, Darren Hart wrote:
> > I'm somewhat concerned that this patch doubles the size of
> > this driver. When we're adding this much code, I have to
> > ask - does it make sense to grow this driver rather than
> > create a new one?
> There'd be a fair amount of code duplication in splitting it.

Yes. dell-laptop.ko implements functions for doing Dell SMBIOS
calls which are needed for keyboard backlight.

> > There is no ACPI backlight driver on these systems? We need
> > a platform driver?
> ACPI doesn't specify keyboard backlight control, so this ends
> up being very vendor specific.

dell-laptop.ko is not ACPI driver. It is using Dell SMBIOS calls.
And I do not know about Dell specific ACPI interface for keyboard
backlight. So Darren, ask this question someone from Dell.

Pali RohÃr

Attachment: signature.asc
Description: This is a digitally signed message part.