Re: FIX ME locking is implemented?

From: Kalle Valo
Date: Sat Nov 22 2014 - 09:41:19 EST

nick <xerofoify@xxxxxxxxx> writes:

> I am wondering why the fix me in the code below still exists as this
> code is clearly being locked properly with a spin lock on the lock
> related to the created linked list in this code.

It would be nice to mention what driver and file you are referring to.
So this is from ath6kl_tx_queue_full() in

> /* FIXME: Locking */
> spin_lock_bh(&ar->list_lock);
> list_for_each_entry(vif, &ar->vif_list, list) {
> if (vif->nw_type == ADHOC_NETWORK ||
> action != HTC_SEND_FULL_DROP) {
> spin_unlock_bh(&ar->list_lock);
> set_bit(NETQ_STOPPED, &vif->flags);
> netif_stop_queue(vif->ndev);
> return action;
> }
> }
> spin_unlock_bh(&ar->list_lock);

Most probably someone just forgot to update the comment, patches welcome :)

Kalle Valo
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at