Re: [PATCH] ipc,sem block sem_lock on sma->lock during sma initialization

From: Andrew Morton
Date: Mon Nov 24 2014 - 15:48:49 EST


On Sun, 23 Nov 2014 19:23:53 +0100 Manfred Spraul <manfred@xxxxxxxxxxxxxxxx> wrote:

> Subject: [PATCH] ipc/sem.c: Fully initialize sem_array before making it
> visible
>
> ipc_addid() makes a new ipc identifier visible to everyone.
> New objects start as locked, so that the caller can complete
> the initialization after the call.
> Within struct sem_array, at least sma->sem_base and sma->sem_nsems
> are accessed without any locks, therefore this approach doesn't work.
>
> Thus: Move the ipc_addid() to the end of the initialization.

Any thoughts on which kernel version(s) need the patch? I'm still
rather fuzzy on the end-user impact of this bug.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/