Re: [PATCH] x86: bpf_jit_comp: simplify trivial boolean return

From: Daniel Borkmann
Date: Wed Nov 26 2014 - 12:57:04 EST


On 11/26/2014 05:58 PM, Joe Perches wrote:
...
imo existing code is fine and I don't think the time spent
reviewing such changes is worth it when there is no
improvement in readability.

+1

Is there any value in reordering these tests for frequency
or maybe using | instead of || to avoid multiple jumps?

No, it's not a fast-path.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/