Re: [PATCH] drivers:cpufreq: Change policy->cpuinfo.transition_latency to correct value

[Viresh Kumar]

On 27 November 2014 at 03:26, Nicholas Krause <xerofoify@xxxxxxxxx> wrote:
> Changes policy->cpuinfo.transition_latency for 1000 to 1000000 nanoseconds
> as we are assuming the latency is 1 millisecond.
>
> Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
> ---
>  drivers/cpufreq/pxa2xx-cpufreq.c | 2 +-
>  drivers/cpufreq/pxa3xx-cpufreq.c | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/cpufreq/pxa2xx-cpufreq.c b/drivers/cpufreq/pxa2xx-cpufreq.c
> index e24269a..2b894aa 100644
> --- a/drivers/cpufreq/pxa2xx-cpufreq.c
> +++ b/drivers/cpufreq/pxa2xx-cpufreq.c
> @@ -372,7 +372,7 @@ static int pxa_cpufreq_init(struct cpufreq_policy *policy)
>         init_sdram_rows();
>
>         /* set default policy and cpuinfo */
> -       policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
> +       policy->cpuinfo.transition_latency = 1000000;

> -       policy->cpuinfo.transition_latency = 1000; /* FIXME: 1 ms, assumed */
> +       policy->cpuinfo.transition_latency = 1000000;

I believe the FIXMEs are still valid and shouldn't be removed. As we are still
running under the assumption here instead of finding out how much is the
latency.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/