Re: [PATCH] sound: use enum names instead of magic numbers

From: Joe Perches
Date: Sun Nov 30 2014 - 14:26:32 EST


On Sun, 2014-11-30 at 10:04 +0100, Takashi Iwai wrote:
> At Sun, 30 Nov 2014 00:55:32 -0800, Joe Perches wrote:
> > On Sun, 2014-11-30 at 09:41 +0100, Takashi Iwai wrote:
> > > At Sat, 29 Nov 2014 12:58:12 -0800, Joe Perches wrote:
> > > > There's an enum defined for these magic numbers,
> > > > might as well use it.
> > > >
> > > > Miscellanea:
> > > > o Use ##__VA_ARGS__
[]
> > Write it as you chose. It is pretty trivial.
>
> ... trivial for anyone ;)

The other option is simply to remove the enum
as the values are unused.


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/