Re: [RFC PATCH 24/30] cputime: Increment kcpustat directly on irqtime account
From: Martin Schwidefsky
Date: Mon Dec 01 2014 - 09:41:40 EST
On Fri, 28 Nov 2014 19:23:54 +0100
Frederic Weisbecker <fweisbec@xxxxxxxxx> wrote:
> The irqtime is accounted is nsecs and stored in
> cpu_irq_time.hardirq_time and cpu_irq_time.softirq_time. Once the
> accumulated amount reaches a new jiffy, this one gets accounted to the
> This was necessary when kcpustat was stored in cputime_t, which could at
> worst have a jiffies granularity. But now kcpustat is stored in nsecs
> so this whole discretization game with temporary irqtime storage has
> become unnecessary.
> We can now directly account the irqtime to the kcpustat.
Isn't the issue here that two different approaches to cputime accounting
get mixed here? On the one hand a cputime_t based on jiffies and on the
other CONFIG_IRQ_TIME_ACCOUNTING which uses sched_clock_cpu() to create
the accounting deltas.
"Reality continues to ruin my life." - Calvin.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/