Re: [PATCH] mtd: gpmi: properly handle bitflips in erased pages
From: Brian Norris
Date: Mon Dec 01 2014 - 14:41:49 EST
On Mon, Dec 01, 2014 at 08:12:39PM +0100, Boris Brezillon wrote:
> Brian, I really like the idea of having a generic implementation for this
> feature (using read_page_raw) as you suggested here , but this implies
> having a temporary buffer to store the page read in raw mode and keep the page
> read in normal (HW ECC engine eanbled) mode, and I'm not sure we want to
> allocate more buffers than we already have.
Why does this require an additional buffer? If we've already noticed an
ECC error, we're expected to return raw data anyway, so what's the
problem with clobbering the original data with a raw version of the
I really *really* do not want to merge another one-off attempt at
"solving" this problem in the low-level driver, if at all possible.
P.S. Sorry for not following up on my last attempt of a generic
solution. I don't think I got enough constructive feedback, other than
"this does not work for me", so I didn't pursue it further. If we have
the attention of more than one driver developer here (i.e., at least you
and me), then I'd really like to finish this off for good (?).
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/