Re: [PATCH] media: platform: add VPFE capture driver support for AM437X
From: Prabhakar Lad
Date: Mon Dec 01 2014 - 17:28:07 EST
On Mon, Dec 1, 2014 at 11:00 AM, Hans Verkuil <hverkuil@xxxxxxxxx> wrote:
> On 12/01/2014 11:11 AM, Hans Verkuil wrote:
>> Hi all,
>> Thanks for the patch, review comments are below.
>> For the next version I would appreciate if someone can test this driver with
>> the latest v4l2-compliance from the v4l-utils git repo. If possible test streaming
>> as well (v4l2-compliance -s), ideally with both a sensor and a STD receiver input.
>> But that depends on the available hardware of course.
>> I'd like to see the v4l2-compliance output. It's always good to have that on
>> On 11/24/2014 02:10 AM, Lad, Prabhakar wrote:
>>> From: Benoit Parrot <bparrot@xxxxxx>
>>> This patch adds Video Processing Front End (VPFE) driver for
>>> AM437X family of devices
>>> Driver supports the following:
>>> - V4L2 API using MMAP buffer access based on videobuf2 api
>>> - Asynchronous sensor/decoder sub device registration
>>> - DT support
>>> Signed-off-by: Benoit Parrot <bparrot@xxxxxx>
>>> Signed-off-by: Darren Etheridge <detheridge@xxxxxx>
>>> Signed-off-by: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
>>> .../devicetree/bindings/media/ti-am437xx-vpfe.txt | 61 +
>>> MAINTAINERS | 9 +
>>> drivers/media/platform/Kconfig | 1 +
>>> drivers/media/platform/Makefile | 2 +
>>> drivers/media/platform/am437x/Kconfig | 10 +
>>> drivers/media/platform/am437x/Makefile | 2 +
>>> drivers/media/platform/am437x/vpfe.c | 2764 ++++++++++++++++++++
>>> drivers/media/platform/am437x/vpfe.h | 286 ++
>>> drivers/media/platform/am437x/vpfe_regs.h | 140 +
>>> include/uapi/linux/Kbuild | 1 +
>>> include/uapi/linux/am437x_vpfe.h | 122 +
>>> 11 files changed, 3398 insertions(+)
> Can the source names be improved? There are too many 'vpfe' sources.
> Perhaps prefix all with 'am437x-'?
I did think of it but, dropped it as anyway the source's are present
in am437x folder, again naming the files am437x-xxx.x didn't make
me feel good. If you still insists I'll do it.
> In general I prefer '-' over '_' in a source name: it's looks better
I am almost done with all the review comments, if we take a decision
on this quickly I can post a v2 soon.
> One question, unrelated to this patch series:
> Prabhakar, would it make sense to look at the various existing TI sources
> as well and rename them to make it more explicit for which SoCs they are
> meant? Most are pretty vague with variations on vpe, vpif, vpfe, etc. but
> no reference to the actual SoC they are for.
vpe - definitely needs to be changed.
vpif - under davinci is common for (Davinci series
vpfe - under davinci is common for (Davinci series dm36x/dm6446/dm355)
I am falling short of names for renaming this common drivers :)
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/