Re: [PATCH v2] fs-fat: Less function calls in fat_fill_super() after error detection

From: Dan Carpenter
Date: Tue Dec 02 2014 - 02:35:10 EST


On Mon, Dec 01, 2014 at 10:22:38PM +0100, SF Markus Elfring wrote:
> >> Which names would be better acceptable for you?
> >
> > You named it after the goto location but the label name should be based
> > on the label location to say what the goto does.
>
> I find it easier occasionally to name a label similarly to the jump target.

That is a useless thing to do.

> It seems that there are a few variations used for the affected identifiers.

There is a lot of crap code in the kernel, yes.

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/