Re: [PATCH V2 RESEND] arm: dts: Exynos5: Use pmu_system_controller phandle for dp phy
From: Jingoo Han
Date: Tue Dec 02 2014 - 03:38:48 EST
On Tuesday, December 02, 2014 5:17 PM, Javier Martinez Canillas wrote:
> Hello Kukjin,
> On Mon, Nov 24, 2014 at 6:41 AM, Vivek Gautam <gautam.vivek@xxxxxxxxxxx> wrote:
> > DP PHY now require pmu-system-controller to handle PMU register
> > to control PHY's power isolation. Adding the same to dp-phy
> > node.
> > Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx>
> > Reviewed-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> > Tested-by: Javier Martinez Canillas <javier.martinez@xxxxxxxxxxxxxxx>
> > Cc: Kukjin Kim <kgene@xxxxxxxxxx>
> Any opinions about $subject?
> This patch is -rc material since is needed after commit a5ec598 ("phy:
> exynos-dp-video: Use syscon
> support to control pmu register") which landed in 3.18. That means
> that display for Exynos is currently broken in 3.18.
> I think it's too late for the 3.18 -rc cycle but at least it would be
> great to have this merged for 3.19 and backport to stable kernels to
> have display working again.
I agree with this suggestion.
> Thierry had concerns that this change breaks DT backward compability
> but actually it was already been broken by a5ec598 which changed the
> DT binding for the phy-exynos-dp-video driver so we should either
> apply this patch now or revert a5ec598.
I think that very few people might use old properties for Exynos DP.
Actually, DT backward compatibility will not be the considerable problem
in my opinion.
But, in order to keep the DT backward compatibility, we should revert
a5ec598, and send another patch for keeping the DT backward compatibility.
> Thanks a lot and best regards,
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/