Re: [PATCH v8 0/3] Qualcomm Resource Power Manager

From: Srinivas Kandagatla
Date: Tue Dec 02 2014 - 09:25:47 EST

Hi Bjorn,

Thanks for the patches, I tested few regulators which are connected to IO devices with this series on IFC6410 with APQ8064 and they work fine. Except one issue which you already are aware of "regulator dependencies on each other" I guess this is another topic which can be discussed separately to this patchset.

Tested-by: Srinivas Kandagatla <srinivas.kandagatla@xxxxxxxxxx>

On 26/11/14 21:50, Bjorn Andersson wrote:
In order to support the SoC assisted power save features of the Qualcomm
platform some changes are most likely needed to the regulator part of the DT
bindings provided before.

This version of the patchset carries the RPM core part, which allows us to move
forward with merging Josh's patches [1] as well as aiding the discussion and
development of the additional patches needed to properly implement the power
save features being discussed.

It also carries the patch to the already merged regulator driver, to make it


Changes since v7:
- Mark merged the regulator part of the previous series
- Removed regulator part of dt binding, for further discussions

Changes since v6:
- Changed filenames from qcom,rpm.{txt,h} to qcom-rpm.{txt,h}

Changes since v5:
- Clarified dt binding
- Converted regulator qcom,force-mode to enum instead of multi-boolean
- Remove unecessary version handshake
- Cleaned up naming of RPM resources between different RPM versions
- Updated regulator qcom,force-mode parsing
- Updated regulator qcom,power-mode-* parsing
- Cleanups in rpm driver
- Dropped dev_get_qcom_rpm helper function

Changes since v4:
- Moved RPM driver to mfd

Changes since v3:
- IPC register is acquired through syscon, as it's shared with others

Changes since v2:
- Fix copy-paste error in dt binding
- Correct incomplete move from mfd to soc
- Correct const mistake in regulator driver

Changes since v1:
- Moved rpm driver to drivers/soc
- Extracted resource table structs from rpm struct, as per Srinivas request
- Dropped mode setting support for the regulators for now. Unsure if we need
it and it requires some rework from the codeaurora solution.
- Using set_voltage_sel instead of rolling my own "snapping", as per Marks
- Split regulator ops in mV, uV and swtich versions as per Marks request.
- Added devicetree property to enable pull down.

Bjorn Andersson (3):
mfd: devicetree: bindings: Add Qualcomm RPM DT binding
mfd: qcom-rpm: Driver for the Qualcomm RPM
regulator: qcom-rpm: Add missing state flag in call to RPM

Documentation/devicetree/bindings/mfd/qcom-rpm.txt | 70 +++
drivers/mfd/Kconfig | 14 +
drivers/mfd/Makefile | 1 +
drivers/mfd/qcom_rpm.c | 581 +++++++++++++++++++++
drivers/regulator/qcom_rpm-regulator.c | 1 +
include/dt-bindings/mfd/qcom-rpm.h | 154 ++++++
include/linux/mfd/qcom_rpm.h | 13 +
7 files changed, 834 insertions(+)
create mode 100644 Documentation/devicetree/bindings/mfd/qcom-rpm.txt
create mode 100644 drivers/mfd/qcom_rpm.c
create mode 100644 include/dt-bindings/mfd/qcom-rpm.h
create mode 100644 include/linux/mfd/qcom_rpm.h


To unsubscribe from this list: send the line "unsubscribe linux-arm-msm" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at