Re: [PATCH 1/2] tpm/tpm_ibmvtpm: Fail in ibmvtpm_get_data if driver_data is bad

From: Anton Blanchard
Date: Tue Dec 02 2014 - 16:20:18 EST


> is this patchset still needed after Vicky's patch
> "[tpmdd-devel] Fix NULL return in tpm_ibmvtpm_get_desired_dma"
> Ashley raised some concerns.
> Since merge window is coming up, a fast reply is appreciated.

We definitely need a way to catch an invalid driver data pointer, but it
looks like that needs to be reworked after Vicky's patch.

Vicky could you look at all uses of ibmvtpm_get_data and make
sure we don't blindly dereference it? eg:

static int tpm_ibmvtpm_resume(struct device *dev)
struct ibmvtpm_dev *ibmvtpm = ibmvtpm_get_data(dev);

rc = plpar_hcall_norets(H_ENABLE_CRQ,

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at