Re: [PATCH 1/2] fs: introduce sendfd() syscall
From: Alex Dubov
Date: Tue Dec 02 2014 - 21:22:40 EST
On Wed, Dec 3, 2014 at 4:00 AM, Al Viro <viro@xxxxxxxxxxxxxxxxxx> wrote:
> On Tue, Dec 02, 2014 at 03:35:18PM +1100, Alex Dubov wrote:
>> + if (rc < 0)
>> + __close_fd(dst_files, s_info.si_int);
> Oh, lovely... And we are guaranteed that it still the same file, because...?
> Not to mention anything else, this stuff violates the assumption used in a lot
> of places - that the *only* way for a process to modify a descriptor table is
> to have a reference to it obtained by something that had it as its current
> descriptor table and not dropped since then. The way you do it might actually
> turn out to be OK, but there's no way I'll take that without detailed analysis;
> start with refcounting of struct file, for one thing - it does rely on the
> assumption above in non-trivial ways.
Ok, I see the problem here. This indeed requires further thought.
> And that's aside of the points other folks had brought up.
Yours is the first insightful message in this thread. Some of the
other commenters exhibited an unfortunate lack of understanding,
regarding what signals are and what they can be useful for.
Unless, of course, I have missed something important.
On a less related note, I hope you will agree that the simpler
mechanism for this very in-demand feature is long overdue on Linux
(every man and his dog are passing fds around these days).
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/