Re: [PATCH v2 net] bpf: x86: fix epilogue generation for eBPF programs
From: Z Lim
Date: Wed Dec 03 2014 - 01:38:21 EST
On Sat, Nov 29, 2014 at 2:46 PM, Alexei Starovoitov <ast@xxxxxxxxxxxx> wrote:
> classic BPF has a restriction that last insn is always BPF_RET.
> eBPF doesn't have BPF_RET instruction and this restriction.
> It has BPF_EXIT insn which can appear anywhere in the program
> one or more times and it doesn't have to be last insn.
Just to confirm, in valid eBPF, BPF_EXIT *must* be present at least
Does an eBPF JIT implementation need to check for it?
> Fix eBPF JIT to emit epilogue when first BPF_EXIT is seen
> and all other BPF_EXIT instructions will be emitted as jump.
> Since jump offset to epilogue is computed as:
> jmp_offset = ctx->cleanup_addr - addrs[i]
> we need to change type of cleanup_addr to signed to compute the offset as:
> (long long) ((int)20 - (int)30)
> instead of:
> (long long) ((unsigned int)20 - (int)30)
> Fixes: 622582786c9e ("net: filter: x86: internal BPF JIT")
> Signed-off-by: Alexei Starovoitov <ast@xxxxxxxxxxxx>
> Note, this bug is applicable only to native eBPF programs
> which first were introduced in 3.18, so no need for stable.
> arm64 JIT has the same problem, but the fix is not as trivial,
> so will be done as separate patch.
I'll cook up a patch for arm64 if you haven't already done so.
Any related test case I should run through?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/