RE: [PATCH net-next] r8152: reduce memory copy for rx

From: Hayes Wang
Date: Wed Dec 03 2014 - 04:09:28 EST


Eric Dumazet [mailto:eric.dumazet@xxxxxxxxx]
> Sent: Wednesday, December 03, 2014 3:15 PM
[...]
> Have you tried using more concurrent RX flows, in a possibly lossy
> environment (so that TCP is forced to queue packets in out of order
> queue) ?

I don't do the test. I would check it next time.

> skb cloning prevents GRO and TCP coalescing from working.
>
> netfilter might also be forced to copy whole frame in case a mangle is
> needed (eg with NAT ...)
>
> I would rather try to implement GRO, and/or using fragments instead of
> pure linear skbs.
>
> (skb->head would be around 128 or 256 bytes, and you attach to skb the
> frame as a page fragment)

Thanks for your response. I would study the GRO first.

Best Regards,
Hayes
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/