Re: [PATCH] Staging: dgnc: Fix long line coding style issues in dgnc_cls.h

From: Dan Carpenter
Date: Wed Dec 03 2014 - 13:10:54 EST

On Wed, Dec 03, 2014 at 09:34:41AM -0800, Greg KH wrote:
> > +#define UART_IIR_CTSRTS 0x20 /*
> > + * Received CTS/RTS change of
> > + * state
> > + */
> That's pretty ugly, don't you think? How about putting the comments on
> the line before the #define, instead of at the end? That would make
> things much nicer to read.

I was going to say the same thing but it looks worse in the mail client
because of how the tabs work out. In the code it doesn't look terrible.

#define UART_IIR_CTSRTS 0x20 /*
* Received CTS/RTS change of
* state

Another idea would be to just remove a tab. It wouldn't align with the
section before but it would align with the next section down.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at