[no subject]

From: Nicholas Krause
Date: Tue Dec 02 2014 - 17:09:02 EST

Remove the FIXME comment in atapi_request_sense() asking whether
memset of sense buffer is necessary. The buffer may be partially or
fully filled by the device. We want it to be cleared.

tj: Updated description.

Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx>
Signed-off-by: Tejun Heo <tj@xxxxxxxxxx>
Applied to libata/for-3.19 with updated description.


drivers/ata/libata-scsi.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/drivers/ata/libata-scsi.c b/drivers/ata/libata-scsi.c
index 1db6eab..6a5fcf1 100644
--- a/drivers/ata/libata-scsi.c
+++ b/drivers/ata/libata-scsi.c
@@ -2595,7 +2595,6 @@ static void atapi_request_sense(struct ata_queued_cmd *qc)

DPRINTK("ATAPI request sense\n");

- /* FIXME: is this needed? */
memset(cmd->sense_buffer, 0, SCSI_SENSE_BUFFERSIZE);


To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/