Re: [PATCH RFC 3/3] virtio_ccw: rev 1 devices set VIRTIO_F_VERSION_1
From: Michael S. Tsirkin
Date: Thu Dec 04 2014 - 13:15:31 EST
On Thu, Dec 04, 2014 at 06:59:14PM +0100, Cornelia Huck wrote:
> On Thu, 4 Dec 2014 19:26:50 +0200
> "Michael S. Tsirkin" <mst@xxxxxxxxxx> wrote:
> > What does it mean if rev 1 device does not set
> > VIRTIO_F_VERSION_1? E.g. is it native endian?
> > Let's not even try to drive such devices:
> > skip attempts to finalize features or set status.
> Why not set status_failed?
It might be cleanest to just teach core that finalize_features
I'll look into this.
> > virtio core will detect this and bail out.
> > Signed-off-by: Michael S. Tsirkin <mst@xxxxxxxxxx>
> > ---
> > drivers/s390/kvm/virtio_ccw.c | 15 +++++++++++++++
> > 1 file changed, 15 insertions(+)
> I'm not sure yet whether I like this approach. I'll think about it over
> the weekend.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/