Re: [PATCH v2 3/3] i2c: cadence: Check for errata condition involving master receive

From: Wolfram Sang
Date: Thu Dec 04 2014 - 13:34:15 EST



> + /*
> + * This controller does not give completion interrupt after a
> + * master receive transfer if HOLD bit is set (repeated start),
> + * resulting in SW timeout. Hence, if a receive transfer is
> + * followed by any other transfer, an error is returned
> + * indicating that this sequence is not supported.
> + */
> + for (count = 0; count < num-1; count++) {
> + if (msgs[count].flags & I2C_M_RD)
> + return -EOPNOTSUPP;
> + }

Yeah, a lot better. Probably it would be good to inform the user with a
warning what went wrong?

Attachment: signature.asc
Description: Digital signature