Re: [PATCH v2 5/6] net-PPP: Delete an unnecessary assignment in mppe_alloc()

From: Dan Carpenter
Date: Fri Dec 05 2014 - 07:23:15 EST

On Thu, Dec 04, 2014 at 11:18:41PM +0100, SF Markus Elfring wrote:
> From: Markus Elfring <elfring@xxxxxxxxxxxxxxxxxxxxx>
> Date: Thu, 4 Dec 2014 22:33:34 +0100
> The data structure element "arc4" was assigned a null pointer by the
> mppe_alloc() function if a previous function call "crypto_alloc_blkcipher"
> failed.

No. crypto_alloc_blkcipher() returns error pointers and not NULL.

This patch creates a bug.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at