Re: [PATCH] staging: lustre: fix sparse warning on LPROC_SEQ_FOPS macros
From: Tristan Lelong
Date: Fri Dec 05 2014 - 17:35:59 EST
On Fri, Dec 05, 2014 at 12:44:07AM -0800, Joe Perches wrote:
> On Fri, 2014-12-05 at 00:37 -0800, Tristan Lelong wrote:
> > On Fri, Dec 05, 2014 at 12:28:11AM -0800, Joe Perches wrote:
> > > On Fri, 2014-12-05 at 00:03 -0800, Tristan Lelong wrote:
> > > > diff --git a/drivers/staging/lustre/lustre/fld/lproc_fld.c b/drivers/staging/lustre/lustre/fld/lproc_fld.c
> > > > + char name;
> > > Why 80? Is there no #define for this length?
> > >
> > No, there is no define.
> > I thought about adding one, but several other files and structure
> > members in the lustre sources are using this specific value, and it
> > seemed like a modification to do in another patch.
> > Let me know if you feel I should do it in a patch serie.
> No worries if it's not a new number.
> It'd be nice if you would submit a new
> patch with a #define and a conversion
> to use the #define one day.
No worries, I'll be happy to submit a patch to fix this soon.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/