Re: [RFC PATCH 09/14] sunrpc: add basic support for workqueue-based services
From: Jeff Layton
Date: Mon Dec 08 2014 - 15:49:31 EST
On Mon, 8 Dec 2014 15:47:09 -0500
"J. Bruce Fields" <bfields@xxxxxxxxxxxx> wrote:
> On Tue, Dec 02, 2014 at 01:24:18PM -0500, Jeff Layton wrote:
> > diff --git a/net/sunrpc/Kconfig b/net/sunrpc/Kconfig
> > index fb78117b896c..08e01949bdc5 100644
> > --- a/net/sunrpc/Kconfig
> > +++ b/net/sunrpc/Kconfig
> > @@ -71,3 +71,13 @@ config SUNRPC_XPRT_RDMA_SERVER
> > choose M here: the module will be called svcrdma.
> > If unsure, say N.
> > +
> > +config SUNRPC_SVC_WORKQUEUE
> > + bool "Support for workqueue-based SUNRPC services"
> > + depends on SUNRPC
> > + default n
> > + help
> > + Traditional SUNRPC services have required a dedicated thread
> > + to handle incoming requests. This option enables support for
> > + queueing incoming reqests to a workqueue instead, eliminating
> > + the need for a dedicated thread pool.
> Minor point, but: If people don't want this, they can turn it off at
> runtime. It's annoying to test all the possible combination of build
> options, and this doesn't seem likely to let people e.g. build a
> significantly smaller kernel, so I wouldn't bother.
Ok, fair enough. I added the config option since this was experimental,
but if we keep it runtime-switchable then I think you're probably right
and there's no need.
Jeff Layton <jlayton@xxxxxxxxxxxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/