Re: [PATCH net-next] macvlan: allow setting LRO independently of lower device

From: David Miller
Date: Tue Dec 09 2014 - 16:00:57 EST

From: Michal Kubecek <mkubecek@xxxxxxx>
Date: Fri, 5 Dec 2014 17:05:49 +0100

> Since commit fbe168ba91f7 ("net: generic dev_disable_lro() stacked
> device handling"), dev_disable_lro() zeroes NETIF_F_LRO feature flag
> first for a macvlan device and then for its lower device. As an attempt
> to set NETIF_F_LRO to zero is ignored, dev_disable_lro() issues a
> warning and taints kernel.
> Allowing NETIF_F_LRO to be set independently of the lower device
> consists of three parts:
> - add the flag to hw_features to allow toggling it
> - allow setting it to 0 even if lower device has the flag set
> - add the flag to MACVLAN_FEATURES to restore copying from lower
> device on macvlan creation
> Signed-off-by: Michal Kubecek <mkubecek@xxxxxxx>

Applied, thanks.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at