Is it a requirement for these property descriptions to be one line? If not, I prefer to stick with the way it is now. Thanks.
On Wed, Dec 10, 2014 at 7:05 AM, Ray Jui <rjui@xxxxxxxxxxxx
On 12/9/2014 5:27 PM, Varka Bhadram wrote:
On Wednesday 10 December 2014 06:24 AM, Ray Jui wrote:
Document the I2C device tree binding for Broadcom iProc
Signed-off-by: Ray Jui <rjui@xxxxxxxxxxxx
Reviewed-by: Scott Branden <sbranden@xxxxxxxxxxxx
.../devicetree/bindings/i2c/__brcm,iproc-i2c.txt | 37
1 file changed, 37 insertions(+)
create mode 100644
new file mode 100644
@@ -0,0 +1,37 @@
+Broadcom iProc I2C controller
+ Must be "brcm,iproc-i2c"
+ Define the base and range of the I/O address space that
+ I2C controller registers
+ Should contain the I2C interrupt
+ This is the I2C bus clock. Need to be either 100000 or
+ Always 1 (for I2C addresses)
+ Always 0
All the properties defined with two lines of statements.
Why cant they be with single line statement, like:
compatible: Must be "brcm,iproc-i2c"
reg: Define the base and range of the I/O address space that
contain the iProc I2C controller registers
I thought making them two lines are more readable (and obviously
that's very subjective, :)). But more importantly, it matches the
format of other Broadcom iProc/Cygnus devicetree binding documents
that are currently in progress of upstreaming.
But max of the bindings over the kernel follows single line statements.
Thanks and Regards,