On 09/12/14 18:24, Ray Jui wrote:Okay. Thanks. I default the driver to y in patchset v3 just like some other I2C drivers in the same Kconfig. It already depends on ARCH_BCM_IPROC so it makes sense to set the default to y, i.e., it will be enabled by default for ARCH_BCM_IPROC platforms.
On 12/9/2014 6:20 PM, Florian Fainelli wrote:
On 09/12/14 18:18, Ray Jui wrote:Yes. So in which case it is better to select a driver from the
Enable I2C driver support for Broadcom iProc family of SoCs by
Signed-off-by: Ray Jui <rjui@xxxxxxxxxxxx>
Reviewed-by: Scott Branden <sbranden@xxxxxxxxxxxx>
arch/arm/mach-bcm/Kconfig | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm/mach-bcm/Kconfig b/arch/arm/mach-bcm/Kconfig
index aaeec78..86ee90b 100644
@@ -19,6 +19,7 @@ config ARCH_BCM_IPROC
+ select I2C_BCM_IPROC
One way to avoid having to modify mach-bcm/Kconfig would be to have your
i2c driver Kconfig do this:
would that work?
architecture specific Kconfig?
I suppose if your driver/subsystem is critical for system boot, like
powering a regulator or something that has a critical purpose, a select
is probably more appropriate here. If this is just exposing non-critical
devices, I would go with a depends on/default at the driver Kconfig level.
This is just how I see things, others would definitively have a
This enables support for systems based on Broadcom IPROC
The IPROC complex contains one or more ARM CPUs along with