Re: [PATCH] staging: lustre: Fix the warning messages about casting without __user macro

From: Al Viro
Date: Wed Dec 10 2014 - 02:10:17 EST


On Tue, Dec 09, 2014 at 10:56:12PM -0800, Shalin Mehta wrote:
> From: Shalin Mehta <shalinmehta85@xxxxxxxxx>
>
> This issue is showed up while compiling with sparse. The iov_base in struct iovec struct explicitly declares that the assigned value should be user space pointer with __user macro. Where as here, the __user macro isn't used while casting.

... and pointers are not user space ones at all. Which is to say, quit
messing with casts; it's not struct iovec. Proper fix is to replace
it here (and in almost all places throughout drivers/staging/lustre) with
struct kvec. And yes, such a patch had been sent. Still not applied,
AFAICS...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/