RE: [PATCH net-next 0/9] r8169:update hardware ephy parameter
Date: Wed Dec 10 2014 - 02:17:21 EST
> From: David Miller [mailto:davem@xxxxxxxxxxxxx]
> Sent: Wednesday, December 10, 2014 7:36 AM
> To: Hau
> Cc: netdev@xxxxxxxxxxxxxxx; nic_swsd; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH net-next 0/9] r8169:update hardware ephy parameter
> From: Chunhao Lin <hau@xxxxxxxxxxx>
> Date: Wed, 10 Dec 2014 00:45:54 +0800
> > Update hardware ephy parameter to improve pcie compatibility.
> This really doesn't tell me anything, I really dislike patch series like this one.
> All of the programming is magic values to magic offsets.
> You aren't even trying to describe in the commit log message exactly what
> kind of settings are being changed, and exactly how those changes achieve
> the stated goal.
> Furthermore, the commit description makes no sense at all to me.
> How can programming the ethernet MAC PHY have any influence on PCI-E
> bus compatability? Or are you programming the PCI bus interface's PHY?
> In what way are you adjusting which settings and in what way do those
> adjustments help improve PCI-E bus behavior?
> You absolutely must describe exactly what the new programming is actually
> doing, precisely, and in detail. I want to know if some kind of timings are
> being adjusted, and in what way.
> Are some fifo limits being changes? If so, in what way, and why does that
> You have to describe what you are doing. Short and non-informative commit
> log messages alongside random changes to undocumented magic constant
> registers is simply unacceptable.
These series patch is an alignment with our latest hardware pcie ephy parameters. I will try to explain more on my next patch.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/