RE: [PATCH V2 1/1] Drivers: hv: vmbus: Fix a bug in vmbus_establish_gpadl()

From: KY Srinivasan
Date: Wed Dec 10 2014 - 19:02:11 EST




> -----Original Message-----
> From: Jeremiah Mahler [mailto:jmmahler@xxxxxxxxx]
> Sent: Wednesday, December 10, 2014 1:46 PM
> To: KY Srinivasan
> Cc: gregkh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx
> Subject: Re: [PATCH V2 1/1] Drivers: hv: vmbus: Fix a bug in
> vmbus_establish_gpadl()
>
> K. Y. Srinivasan,
>
> On Wed, Dec 10, 2014 at 12:29:19PM -0800, K. Y. Srinivasan wrote:
> > Fix a bug in vmbus_establish_gpadl(). I would like to thank Michael
> > Brown <mcb30@xxxxxxxx> for seeing this bug.
> > In this version, I have added the Reported-by tag.
>
> The log message should be more specific. "Fix a bug" is too vague.
> Why is this patch necessary? What bug does it fix? What changes did you
> make?
>
> Saying you have "added the Reported-by tag" is not helpful in a log message.
> Although you can add notes for the patch reviewer under '---'.

Thank you; I will fix up the log and resend.

K. Y
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/