Re: [RFC 04/15] regulator: add restrack support
From: Mark Brown
Date: Thu Dec 11 2014 - 07:59:39 EST
On Thu, Dec 11, 2014 at 11:49:54AM +0100, Andrzej Hajda wrote:
> On 12/10/2014 05:07 PM, Mark Brown wrote:
> > On Wed, Dec 10, 2014 at 04:48:22PM +0100, Andrzej Hajda wrote:
> >> Regulators supports various methods of lookup.
> >> The patch adds restrack support only to DT based regulators.
> > Why, what does this mean and how might one use it? I've not looked at
> > the code since I don't know what it's supposed to accomplish...
> Looking at this patch makes no sense without looking at cover letter
> or at the patch adding restrack framework. In short adding restrack support
> to regulators will allow to:
I did look at the cover letter and glance at the first couple of patches
but I still can't tell what this is really intended to do. There's a
lot of implementation detail but not a lot of high level overview so
it's not very clear to me how exactly this solves problems or how it is
different to the component framework, it sounds very similar.
I'd expect someone reading the change in the regulator API to have at
least some idea how this fits in with the rest of the API and how to use
it, and probably more importantly I'd expect to be able to understand
why this is DT only.
Description: Digital signature