Re: [PATCH v6 2/5] Documentation: bindings: add dt documentation for Rockchip usb PHY
From: Doug Anderson
Date: Thu Dec 11 2014 - 13:46:18 EST
On Thu, Dec 11, 2014 at 1:55 AM, Yunzhi Li <lyz@xxxxxxxxxxxxxx> wrote:
> This patch adds a binding that describes the Rockchip usb PHYs
> found on Rockchip SoCs usb interface.
Technically the bindings patch is supposed to come before the driver.
So this should be patch #1 and the driver patch #2.
> +Required properties:
> + - compatible: rockchip,rk3288-usb-phy
> + - rockchip,grf : phandle to the syscon managing the "general
> + register files"
> + - #phy-cells: should be 1
> + - #address-cells: should be 1
> + - #size-cells: should be 0
> +Each PHY should be represented as a sub-node.
> +required properties:
> +- reg: the PHY number
> + "0" - PHY connect to OTG controller
> + "1" - PHY connect to HOST0 controller
> + "2" - PHY connect to HOST1 controller
You don't have any sub nodes and are using the phy-cells. Seems like
you should get rid of this? ...or I guess switch to using sub nodes
and set "phy-cells" to 0?
> +Optional Properties:
> +- clocks : phandle + clock specifier for the phy clocks
As per earlier, you should get rid of clocks. If you really want a
clock here and it's optional:
* Back in the driver it shouldn't be a "warn". You don't warn when
optional things are missing.
* You really should specify a clock name. Right now this will pick
the first clock, which makes it hard to later add clocks.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/