Re: [PATCH] Make /proc/<pid>/io world readable

From: Djalal Harouni
Date: Thu Dec 11 2014 - 14:29:20 EST


Hi,

On Thu, Dec 11, 2014 at 05:22:28PM +0100, Marcel Mol wrote:
> /proc/<pid>/io is only readable by the pid owner, while files
> like stat, statm and status are world readable.
> I see no reason why io statistics should be hidden.
> This patch makes io also world readable so process io counts
> can be analysed without root permissions.
As Andy noted this should be the other way around! so unless you have
a real usecase, this will revert previous patch by Vasiliy that closed
some info leaks...
https://lkml.org/lkml/2011/7/27/459

Thanks!

> Signed-off-by: Marcel Mol <marcel@xxxxxxx>
> ---
> fs/proc/base.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/fs/proc/base.c b/fs/proc/base.c
> index 772efa4..7bd8dbe 100644
> --- a/fs/proc/base.c
> +++ b/fs/proc/base.c
> @@ -2563,7 +2563,7 @@ static const struct pid_entry tgid_base_stuff[] = {
> REG("coredump_filter", S_IRUGO|S_IWUSR, proc_coredump_filter_operations),
> #endif
> #ifdef CONFIG_TASK_IO_ACCOUNTING
> - ONE("io", S_IRUSR, proc_tgid_io_accounting),
> + ONE("io", S_IRUGO, proc_tgid_io_accounting),
> #endif
> #ifdef CONFIG_HARDWALL
> ONE("hardwall", S_IRUGO, proc_pid_hardwall),
> @@ -2904,7 +2904,7 @@ static const struct pid_entry tid_base_stuff[] = {
> REG("make-it-fail", S_IRUGO|S_IWUSR, proc_fault_inject_operations),
> #endif
> #ifdef CONFIG_TASK_IO_ACCOUNTING
> - ONE("io", S_IRUSR, proc_tid_io_accounting),
> + ONE("io", S_IRUGO, proc_tid_io_accounting),
> #endif
> #ifdef CONFIG_HARDWALL
> ONE("hardwall", S_IRUGO, proc_pid_hardwall),
> --
> 1.9.3
>
>

--
Djalal Harouni
http://opendz.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/