Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

From: Lars-Peter Clausen
Date: Sat Dec 13 2014 - 06:26:00 EST

On 12/13/2014 12:18 PM, Hartmut Knaack wrote:
According to your DT bindings, the regulator from property "vref-supply" should
be used. This is missing here.

Uhm, it's right below, no?
Looking into your DT bindings patch (which unfortunately didn't make it into our
list), you specify "vref-supply" as a required property. So, I expected that you
intended to make use of this property somewhere around here.

The regulator framework takes care of this. If you request a regulator with $name the framework will look for a property with the name $name-supply.

+ st->reg =evm_regulator_get(&spi->dev, "vref");
+ if (IS_ERR(st->reg))
+ return PTR_ERR(st->reg);

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at