Re: [PATCH v2 2/2] iio: add driver for the TI DAC8554

From: Lars-Peter Clausen
Date: Sat Dec 13 2014 - 06:33:14 EST


On 12/06/2014 12:36 PM, Hartmut Knaack wrote:
[...]
+static int dac8554_read_raw(struct iio_dev *indio_dev,
+ struct iio_chan_spec const *chan,
+ int *val,
+ int *val2,
+ long m)
Commonly, m is called mask (like you do in _write_raw).

We should call it info in new driver. It used to be a mask, but that was a long long time ago.

[...]
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/