Re: [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c

From: Jens Axboe
Date: Sun Dec 14 2014 - 21:40:58 EST


On 12/13/2014 08:09 PM, Nicholas Krause wrote:
Removes unneeded fix me comment related to the function, add_disk needing error handling. The function clearly has supported this for a while and the comment is not longer needed
for the function,add_disk in the file genhd.c.

But it doesn't, really. Proper error handling would be to unroll and return the error, if it happens. Right now add_disk() can't return an error.

--
Jens Axboe

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/