Re: [PATCH] drivers:block: Remove no longer needed FIXME comment for the function, add_disk in genhd.c

From: Jens Axboe
Date: Sun Dec 14 2014 - 21:54:37 EST

On 12/14/2014 07:46 PM, nick wrote:
After rechecking the function definition we can't return an error as add_disk is declared void. Should I change the function to an int and then return an error. My thinking was that there is no good way to return an error code without
a breakage in the functions that call add_disk.

Please don't top post...

It's a big job, it requires properly checking and updating all block drivers. But yes, that is what would be required in removing that TODO.

Jens Axboe

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at