Re: [PATCH 1/8] nfs: follow direct I/O write locking convention
From: Trond Myklebust
Date: Mon Dec 15 2014 - 07:49:27 EST
On Mon, Dec 15, 2014 at 12:26 AM, Omar Sandoval <osandov@xxxxxxxxxxx> wrote:
> The generic callers of direct_IO lock i_mutex before doing a write. NFS
> doesn't use the generic write code, so it doesn't follow this
> convention. This is now a problem because the interface introduced for
> swap-over-NFS calls direct_IO for a write without holding i_mutex, but
> other implementations of direct_IO will expect to have it locked.
I really don't care much about swap-over-NFS performance; that's a
niche usage at best. I _do_ care about O_DIRECT performance, and the
ability to run multiple WRITE calls in parallel.
IOW: Patch NACKed... Please find another solution.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/