Re: [PATCH] checkpatch giving bogus advice (was staging: goldfish: Fix minor coding style)

From: Dan Carpenter
Date: Mon Dec 15 2014 - 08:44:19 EST

On Mon, Dec 15, 2014 at 05:03:46AM -0800, Jeremiah Mahler wrote:
> Or another way mentioned in K&R that produces a compile error
> if (NULL = x)

Yes. People used to write Yoda code back in the day. Don't ever do
this in the kernel.

1) It looks stupid.
2) GCC will catch most == vs = bugs as Alan pointed out.
3) There are still some that sneak through because people put double
parenthesis around everything like "if ((foo = NULL) || (...)) {",
but and Smatch will catch those.

dan carpenter

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at