Re: [PATCH 2/2] Staging: lustre: lproc_osc.c: used seq_puts() instead of seq_printf()

From: Joe Perches
Date: Wed Dec 17 2014 - 13:22:39 EST


On Wed, 2014-12-17 at 23:29 +0530, Hariharan Rangasamy wrote:
> Replaced seq_printf() with seq_puts()
[]
> diff --git a/drivers/staging/lustre/lustre/osc/lproc_osc.c b/drivers/staging/lustre/lustre/osc/lproc_osc.c
[]
> @@ -358,7 +358,7 @@ static int osc_checksum_type_seq_show(struct seq_file *m, void *v)
> else
> seq_printf(m, "%s ", cksum_name[i]);
> }
> - seq_printf(m, "\n");
> + seq_puts(m, "\n");

This could be seq_putc

> return 0;
> }
>
> @@ -590,7 +590,7 @@ static int osc_rpc_stats_seq_show(struct seq_file *seq, void *v)
> seq_printf(seq, "pending read pages: %d\n",
> atomic_read(&cli->cl_pending_r_pages));
>
> - seq_printf(seq, "\n\t\t\tread\t\t\twrite\n");
> + seq_puts(seq, "\n\t\t\tread\t\t\twrite\n");
> seq_printf(seq, "pages per rpc rpcs %% cum %% |");
> seq_printf(seq, " rpcs %% cum %%\n");

These and others could be seq_puts too, just use % instead of %%


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/