Re: [PATCH v2] mm/zsmalloc: add statistics support

From: Minchan Kim
Date: Fri Dec 19 2014 - 19:55:15 EST


On Sat, Dec 20, 2014 at 09:23:03AM +0900, Minchan Kim wrote:
> On Fri, Dec 19, 2014 at 04:17:56PM -0800, Andrew Morton wrote:
> > On Sat, 20 Dec 2014 09:10:43 +0900 Minchan Kim <minchan@xxxxxxxxxx> wrote:
> >
> > > > It involves rehashing a lengthy argument with Greg.
> > >
> > > Okay. Then, Ganesh,
> > > please add warn message about duplicaed name possibility althoug
> > > it's unlikely as it is.
> >
> > Oh, getting EEXIST is easy with this patch. Just create and destroy a
> > pool 2^32 times and the counter wraps ;) It's hardly a serious issue
> > for a debugging patch.
>
> I meant that I wanted to change from index to name passed from caller like this
>
> zram:
> zs_create_pool(GFP_NOIO | __GFP_HIGHMEM, zram->disk->first_minor);

Correction for clear my intention

sprintf(buf, "%zram%d", zram->disk->first_minor);
zs_create_pool(GFP_NOIO | __GFP_HIGHMEM, buf);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/