Re: [PATCH v4 1/5] ASoC: dwc: Prepare clock before use

From: Andrew Jackson
Date: Wed Dec 24 2014 - 01:57:07 EST


On 12/23/14 13:56, Andrew Jackson wrote:
> From: Andrew Jackson <Andrew.Jackson@xxxxxxx>
>
> Some I2S clocks may require some time to get the clock ready
> for operation and so need to be prepared before they are enabled.
> So, prepare the clock as well as enabling it, but combine the
> two through clk_prepare_enable.

More turkey-focussed issues: this should have a clk_disable_unprepare too. Sigh

Andrew

> Signed-off-by: Andrew Jackson <Andrew.Jackson@xxxxxxx>
> ---
> sound/soc/dwc/designware_i2s.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/sound/soc/dwc/designware_i2s.c b/sound/soc/dwc/designware_i2s.c
> index 06d3a34..9573ec7 100644
> --- a/sound/soc/dwc/designware_i2s.c
> +++ b/sound/soc/dwc/designware_i2s.c
> @@ -411,7 +411,7 @@ static int dw_i2s_probe(struct platform_device *pdev)
> if (IS_ERR(dev->clk))
> return PTR_ERR(dev->clk);
>
> - ret = clk_enable(dev->clk);
> + ret = clk_prepare_enable(dev->clk);
> if (ret < 0)
> goto err_clk_put;
>
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/