Re: [PATCH] staging: iio: accel: sca3000_core.c: Remove unused function

From: Jonathan Cameron
Date: Fri Dec 26 2014 - 07:40:57 EST


On 20/12/14 14:53, Rickard Strandqvist wrote:
> Remove the function sca3000_check_status() that is not used anywhere.
>
> This was partially found by using a static code analysis program called cppcheck.
>
> Signed-off-by: Rickard Strandqvist <rickard_strandqvist@xxxxxxxxxxxxxxxxxx>
Applied to the togreg branch of iio.git - initially pushed out as testing
for the autobuilders to play with it.

Thanks,

Jonathan
> ---
> drivers/staging/iio/accel/sca3000_core.c | 27 ---------------------------
> 1 file changed, 27 deletions(-)
>
> diff --git a/drivers/staging/iio/accel/sca3000_core.c b/drivers/staging/iio/accel/sca3000_core.c
> index e4e5639..655e34c 100644
> --- a/drivers/staging/iio/accel/sca3000_core.c
> +++ b/drivers/staging/iio/accel/sca3000_core.c
> @@ -223,33 +223,6 @@ error_ret:
> return ret;
> }
>
> -#ifdef SCA3000_DEBUG
> -/**
> - * sca3000_check_status() check the status register
> - *
> - * Only used for debugging purposes
> - **/
> -static int sca3000_check_status(struct device *dev)
> -{
> - int ret;
> - struct iio_dev *indio_dev = dev_to_iio_dev(dev);
> - struct sca3000_state *st = iio_priv(indio_dev);
> -
> - mutex_lock(&st->lock);
> - ret = sca3000_read_data_short(st, SCA3000_REG_ADDR_STATUS, 1);
> - if (ret < 0)
> - goto error_ret;
> - if (st->rx[0] & SCA3000_EEPROM_CS_ERROR)
> - dev_err(dev, "eeprom error\n");
> - if (st->rx[0] & SCA3000_SPI_FRAME_ERROR)
> - dev_err(dev, "Previous SPI Frame was corrupt\n");
> -
> -error_ret:
> - mutex_unlock(&st->lock);
> - return ret;
> -}
> -#endif /* SCA3000_DEBUG */
> -
> /**
> * sca3000_show_rev() - sysfs interface to read the chip revision number
> **/
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/