Re: [PATCH net-next 1/2] socket: Allow external sockets to use socket syscalls

From: Alex Gartrell
Date: Fri Dec 26 2014 - 15:00:24 EST

Hello Al,

On 12/26/14 2:56 PM, Al Viro wrote:
On Thu, Dec 25, 2014 at 10:50:23PM -0800, Alex Gartrell wrote:
Currently the "is-socket" test for a file compares the ops table pointer,
which is static and local to the socket.c. Instead, this adds a flag for
private_data_is_socket. This is an exceptionally long commit message for a
two-line patch.

NAK. Don't crap into struct file, please.

I don't disagree with your sentiment here. Is the additional f_op approach less gross or do you have something else in mind?

Alex Gartrell <agartrell@xxxxxx>
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at