Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line
From: RafaÅ MiÅecki
Date: Sat Dec 27 2014 - 18:43:09 EST
On 27 December 2014 at 23:04, Oscar Forner Martinez
> 2014-12-27 21:14 GMT+00:00 Oscar Forner Martinez
>> 2014-12-27 20:19 GMT+00:00 RafaÅ MiÅecki <zajec5@xxxxxxxxx>:
>>> On 27 December 2014 at 20:24, Oscar Forner Martinez
>>> <oscar.forner.martinez@xxxxxxxxx> wrote:
>>> > Three lines with more than 80 characters per line have been split in
>>> > several lines.
>>> Thanks for the next version :)
>>> 1) You missed version number. Something like
>>> git format-patch --subject-prefix="PATCH V3"
>>> (you saying for the future).
>> Yes, sorry I forgot to put -v 3 in git format-patch.
>>> 2) I'm OK with your changes, but when checking the patch I get some
>>> errors like
>>> ERROR: trailing whitespace
>>> ERROR: DOS line endings
>>> (I used ./scripts/checkpatch.pl, see attached checkpatch log).
>>> I think that "trailing whitespace" errors are caused by DOS line
>>> endings, because I don't see anything wrong about your code.
>>> Is there something wrong with your emacs? git-send-email shouldn't
>>> malform patches I believe.
>> When I run ./scripts/checkpatch.pl with my patch does not show any error
>> (please find attached the output). I will try to run it with the one from my
>> e-mail. My only configuration in the .emacs file is: (setq c-default-style
> I ran the ./scripts/checkpatch.pl with the patch got it from
> http://marc.info/?l=linux-wireless&m=141970834908165 and it does not show
> any error. Could you please tell me how I have to check in the same way as
> you did?
False alarm, sorry. GMail changed sth again or my browser
change/update broke saving e-mails.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/