Re: [RFC][PATCH RESEND] mm: vmalloc: remove ioremap align constraint
From: Arnd Bergmann
Date: Sun Dec 28 2014 - 07:51:41 EST
On Tuesday 23 December 2014 13:00:13 Dmitry Safonov wrote:
> ioremap uses __get_vm_area_node which sets alignment to fls of requested size.
> I couldn't find any reason for such big align. Does it decrease TLB misses?
> I tested it on custom ARM board with 200+ Mb of ioremap and it works.
> What am I missing?
The alignment was originally introduced in this commit:
Author: Russell King <rmk@xxxxxxxxxxxxxxxxxxxxxxx>
Date: Thu Jun 29 20:17:15 2006 +0100
[ARM] Add section support to ioremap
Allow section mappings to be setup using ioremap() and torn down
with iounmap(). This requires additional support in the MM
context switch to ensure that mappings are properly synchronised
when mapped in.
Based an original implementation by Deepak Saxena, reworked and
ARMv6 support added by rmk.
Signed-off-by: Russell King <rmk+kernel@xxxxxxxxxxxxxxxx>
and then later extended to 16MB supersection mappings, which indeed
is used to reduce TLB pressure.
I don't see any downsides to it, why change it?
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/