Re: [PATCH] bcma: fix three coding style issues, more than 80 characters per line
From: Arend van Spriel
Date: Sun Dec 28 2014 - 10:01:17 EST
On 12/28/14 15:02, RafaÅ MiÅecki wrote:
On 28 December 2014 at 10:12, Sedat Dilek<sedat.dilek@xxxxxxxxx> wrote:
On Sun, Dec 28, 2014 at 9:53 AM, RafaÅ MiÅecki<zajec5@xxxxxxxxx> wrote:
On 28 December 2014 at 06:50, Sedat Dilek<sedat.dilek@xxxxxxxxx> wrote:
On Sun, Dec 28, 2014 at 12:44 AM, RafaÅ MiÅecki<zajec5@xxxxxxxxx> wrote:
On 27 December 2014 at 20:24, Oscar Forner Martinez
<oscar.forner.martinez@xxxxxxxxx> wrote:
Three lines with more than 80 characters per line have been split in several lines.
Signed-off-by: Oscar Forner Martinez<oscar.forner.martinez@xxxxxxxxx>
Acked-by: RafaÅ MiÅecki<zajec5@xxxxxxxxx>
As for the comment-line changes... 80+ chars are allowed for better readability.
So, please don't do that.
[ Checkpatch should not warn on this especially for comments. ]
We almost always split long comments into separated lines in the
kernel. What's different with this case?
1st it is not mandatory.
2nd it is more readable in one line.
- /* 4706 CC and PMU watchdogs are clocked at
1/4 of ALP clock */
+ /* 4706 CC and PMU watchdogs are clocked at 1/4 of ALP
+ * clock
+ */
I agree with you when the comment would be longer.
So I guess there is some rule like
"Don't use 2 lines if there is 80 chars + one word"
? Where can I find such rules?
Personally, I don't like taking this sliding slope. Just stick to the 80
characters rule and add a few words in the comment, eg:
/* The BCM4706 ChipCommon and PMU watchdogs are
* clocked at one quarter of the ALP clock.
*/
Regards,
Arend
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/