Re: [PATCH] srcu: Isolate srcu sections using CONFIG_SRCU

From: Martin Schwidefsky
Date: Mon Dec 29 2014 - 05:03:47 EST

On Sat, 27 Dec 2014 12:17:43 -0500
Pranith Kumar <bobby.prani@xxxxxxxxx> wrote:

> @@ -65,10 +65,13 @@
> #include <asm/kexec.h>
> #include <asm/mmu_context.h>
> #include <asm/code-patching.h>
> -#include <asm/kvm_ppc.h>
> #include <asm/hugetlb.h>
> #include <asm/epapr_hcalls.h>
> +#include <asm/kvm_ppc.h>
> +#endif
> +
> #ifdef DEBUG
> #define DBG(fmt...) udbg_printf(fmt)
> #else

I always cringe when I see an include protected by an #ifdef.
Is this really necessary? All that is done in asm-offsets.c is
to calculate offsets, the code where the two offsets in question
are used (entry64.S) does have the #ifdef for CONFIG_KVM.

blue skies,

"Reality continues to ruin my life." - Calvin.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at
Please read the FAQ at