Re: [PATCH 1/2] regulator: core: Add a sanity check on the regulator_ enable/disable functions

From: Mark Brown
Date: Mon Dec 29 2014 - 10:41:06 EST

On Fri, Dec 26, 2014 at 06:26:38PM +0100, Gregory CLEMENT wrote:
> These two functions use the pointer passed in parameter without any
> check. By adding a NULL pointer check, it allows using those functions
> from a driver in a more generic way. It is useful especially for the
> disable case if the regulator is optional.

No, especially in the case of regulator_enable() this is deliberate -
we're trying to ensure that if people are using regulators they're being
careful about it, checking error codes and so on. I'd really want to
see some persuasive use case for this. What you're saying here sounds
like the consumer shouldn't be treating the regulator as optional at
all but should instead be using a normal regulator.

Attachment: signature.asc
Description: Digital signature