Re: [PATCH] ALSA: ASoC: soc-compress.c: fix NULL dereference

From: Mark Brown
Date: Mon Dec 29 2014 - 11:13:36 EST

On Tue, Dec 23, 2014 at 09:09:27AM +0000, Qais Yousef wrote:
> In soc_new_compress() when rtd->dai_link->daynmic is set, we create the pcm
> substreams with this call:
> ret = snd_pcm_new_internal(rtd->card->snd_card, new_name, num,
> 1, 0, &be_pcm);
> which passes 0 as capture_count leading to
> be_pcm->streams[SNDRV_PCM_STREAM_CAPTURE].substream
> being NULL, hence when trying to set rtd a few lines below we get an oops.
> Fix by removing this line of code since CAPTURE substream will always be NULL.

Why will the capture stream always be NULL? There should be no
intrinsic reason why we can't have hardware support for capturing
compressed audio.

Attachment: signature.asc
Description: Digital signature